search

IgniteUI / igniteui-angular-samples

Ignite UI for Angular demos for all available components and features
https://bit.ly/2L19rhp
36 stars 25 forks source link

Stackblitz samples incorrect theme results (roundness) #3355

Closed damyanpetev closed 1 year ago

damyanpetev commented 1 year ago

Description

Stackblitz samples produces from the docs produce a project setup w/ igniteui-theming that produces wrong app styles. Possibly related to https://github.com/IgniteUI/igniteui-angular/issues/13108

Steps to reproduce

  1. Go to https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/export-excel#angular-excel-exporter-example (likely true for all samples
  2. Open the demo in Stackblitz
  3. Wait for the app to load

Result

Snapshot at time of creation https://stackblitz.com/edit/1mpppp?file=package.json The issue is with a project dependency: image When in reality the latest version of igniteui-angular depends v2: image

That causes a lot of square UI with the default theme: image

Expected result

Versions should be updated or since igniteui-angular lists as direct dependency, then the produced live editing samples should not include it as a direct dependency at all (assuming the module ends up in the correct place for load paths). //CC @simeonoff In case the expectation is quite right

Attachments

Attach a sample if available, and screenshots, if applicable.

simeonoff commented 1 year ago

@damyanpetev @hanastasov for igniteui-angular 16.0.7+ the version of the theming package has been updated to ^2.0.0. If theming is not explicitly needed for some reason as part of the stackblitz package.json, we should remove it. The theming package is a direct dependancy of igniteui-angular as Damyan said.