search

IgniteUI / igniteui-angular-wrappers

Ignite UI Angular component extensions by Infragistics
http://igniteui.github.io/igniteui-angular-wrappers
MIT License
148 stars 30 forks source link

addRow and deleteRow method are unexpectedly defined in IgGridBase<Model> class #255

Closed ymita closed 6 years ago

ymita commented 6 years ago

Description

addRow and deleteRow method are unexpectedly defined in IgGridBase class.

Steps to reproduce

  1. Open iggridbase.d.ts and observe IgGridBase class

Result

addRow and deleteRow are defined.

Expected result

addRow and deleteRow are not defined as these methods are already defined in IgGridUpdatingFeature class.

dkamburov commented 6 years ago

addRow and deleteRow in IgGridBase are different from addRow and deleteRow in IgGridUpdatingFeature. Methods in IgGridBase are part of the data binding capabilities of the grids and are used when changes into the data source are detected. If you want to use the updating functionality you should use the methods from IgGridUpdatingFeature.

dkamburov commented 6 years ago

@ymita If you have further questions, please re-open the issue

ymita commented 6 years ago

@dkamburov

Calling deleteRow from IgGridUpdating throws an undefined error. Is this the expected way to call deleteRow? The attached is the sample that I am working on my end.

  myClick() {
    this.hgrid1.featuresList.updating.deleteRow(0);
  }

image

hierarchicalGrid.zip

dkamburov commented 6 years ago

This is is getting resolved with issue #257, unfortunately there is no recently tagged version so the fix is not publicly available.

dkamburov commented 6 years ago

Resolved in 6.0.0 version hierarchicalGrid.zip

ymita commented 6 years ago

@dkamburov thank you for letting me know. I confirm it is fixed.