search

IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
571 stars 160 forks source link

Icon button color is overridden by theme color #13977

Closed ddincheva closed 1 month ago

ddincheva commented 6 months ago

Description

Steps to reproduce

  1. Add an icon button and set its color to a custom color, let's say Secondary-500
  2. Add a navigation bar and change the color of the button icon in the navbar to the same color

Result

The icon button in the navbar is always black, the theme overrides the custom color set.

image

Expected result

The set colors should be applied

NOTE: The isssue is related with this change https://github.com/IgniteUI/igniteui-angular/pull/13759

github-actions[bot] commented 4 months ago

There has been no recent activity and this issue has been marked inactive.

SisIvanova commented 2 months ago

@ddincheva This issue has been fixed with the navbar theme changes in this PR. The problem can now be reproduced only in version 17.1.x but it's ok in 17.2.x, 18.0.x and master.

Screenshot 2024-06-19 at 11 38 04 AM
simeonoff commented 1 month ago

@hanastasov Is the issue still reproducible? As Sisi stated, it has been fixed in 18.0 and 18.1.x.

hanastasov commented 1 month ago

@hanastasov Is the issue still reproducible? As Sisi stated, it has been fixed in 18.0 and 18.1.x.

I assigned it to you, as you have been the one fixing this issue with PR https://github.com/IgniteUI/igniteui-angular/pull/14126. However, I have not verified whicj version works and which does not, since Sisi already did it.

simeonoff commented 1 month ago

Then I'm closing the issue.