feat(slider): implement indigo slider changes

IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.

https://www.infragistics.com/products/ignite-ui-angular

Other

569 stars 159 forks source link

feat(slider): implement indigo slider changes #14274

Closed didimmova closed 1 month ago

didimmova commented 1 month ago

Related to this issue

Additional information (check all that apply):

[ ] Bug fix
[ ] New functionality
[ ] Documentation
[ ] Demos
[ ] CI/CD

Checklist:

[ ] All relevant tags have been applied to this PR
[ ] This PR includes unit tests covering all the new code (test guidelines)
[ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
[ ] This PR includes feature/README.MD updates for the feature docs
[ ] This PR includes general feature table updates in the root README.MD
[ ] This PR includes CHANGELOG.MD updates for newly added functionality
[ ] This PR contains breaking changes
[ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
[ ] This PR includes behavioral changes and the feature specification has been updated with them

sbayreva commented 1 month ago

The space between the Tickmarks and the track should be 4px, now what I find is “bottom: 0.1875 rem” which in px is 3. I am not sure if it takes another 1px from somewhere.

@andiesm813 , please check if there is anything else you want to add.

didimmova commented 1 month ago

The space between the Tickmarks and the track should be 4px, now what I find is “bottom: 0.1875 rem” which in px is 3. I am not sure if it takes another 1px from somewhere.

@andiesm813 , please check if there is anything else you want to add.

Because initially the bottom was 0 and the space was 7px, I moved it 3px to the top, so now it's 4px.

sbayreva commented 1 month ago

The space between the Tickmarks and the track should be 4px, now what I find is “bottom: 0.1875 rem” which in px is 3. I am not sure if it takes another 1px from somewhere. @andiesm813 , please check if there is anything else you want to add.

Because initially the bottom was 0 and the space was 7px, I moved it 3px to the top, so now it's 4px.

Everything is verified by my side. Waiting for @andiesm813 approval.

andiesm813 commented 1 month ago

All good to me here as well! ✅✅✅