IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
569 stars 159 forks source link

feat(slider): implement indigo slider changes #14277

Closed didimmova closed 1 month ago

didimmova commented 1 month ago

Additional information (check all that apply):

Checklist:

sbayreva commented 1 month ago
  1. The space between the tick marks and the base track should be 4px

  2. The thumb cannot be slid to 0 in this example:

    Screenshot 2024-05-29 at 16 13 44
  3. The space between tickmarks and labels should be 4px

@andiesm813 Please, check whether there is something else you need to add.

didimmova commented 1 month ago
  1. The space between the tick marks and the base track should be 4px
  2. The thumb cannot be slid to 0 in this example:
Screenshot 2024-05-29 at 16 13 44
  1. The space between tickmarks and labels should be 4px

@andiesm813 Please, check whether there is something else you need to add.

This sample's thumb isn't going to 0 because the sample has lower bound set to 20.

sbayreva commented 1 month ago
  1. The space between the tick marks and the base track should be 4px
  2. The thumb cannot be slid to 0 in this example:
Screenshot 2024-05-29 at 16 13 44
  1. The space between tickmarks and labels should be 4px @andiesm813 Please, check whether there is something else you need to add.

This sample's thumb isn't going to 0 because the sample has lower bound set to 20.

Verified by my side, waiting for @andiesm813 approval.

andiesm813 commented 1 month ago

Looks good to me! I assume by the time i reviewed this, comments 1 and 3 were fixed. So verified! ;)

  1. The space between the tick marks and the base track should be 4px
  2. The thumb cannot be slid to 0 in this example:
Screenshot 2024-05-29 at 16 13 44
  1. The space between tickmarks and labels should be 4px

@andiesm813 Please, check whether there is something else you need to add.