IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
568 stars 159 forks source link

fix(migrations): improve migration to take @use and @forward into acc #14298

Closed ChronosSF closed 1 month ago

ChronosSF commented 1 month ago

Closes #

Additional information (check all that apply):

Checklist:

mddragnev commented 1 month ago

Probably if there is a @import at the top, it should stay there too.

ChronosSF commented 1 month ago

Probably if there is a @import at the top, it should stay there too.

Eh not really sure about that... Since it's not a rule to have the imports at the top if I apply the same logic and the last import is somewhere down it might become an issue. What if imports can be put inside css rules too?

mddragnev commented 1 month ago

Probably if there is a @import at the top, it should stay there too.

Eh not really sure about that... Since it's not a rule to have the imports at the top if I apply the same logic and the last import is somewhere down it might become an issue. What if imports can be put inside css rules too?

This is my bad. Because it is invalid to have imports other place than at the top of a css file, yet it is valid in Sass.