IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
568 stars 159 forks source link

fix(overlay): On Safari set width/height/min-width to 0 when the togg… #14317

Closed mddragnev closed 1 month ago

mddragnev commented 1 month ago

…le is hidden

Closes #14303

Additional information (check all that apply):

Checklist:

damyanpetev commented 1 month ago

Assuming this is related to the previous fix from #14167 and that fix doesn't play well w/ older versions - can we check with 17.5 if that's returned to the previous state and doesn't work for that either? We could either decide if that fix can be dropped though 17.4 seems to be still quite prevalent or attempt to version-lock it. Looking at the changelogs for 17.4 & 17.5 something like

@supports (content: url("test.png") / "Alt text") and (not (text-wrap-style: balance)) { }

should give us exactly 17.4 and we can lock that workaround there for a while and everything else can go back to good ol' display none? Just an idea.

Edit: Nvm, didn't notice the fix is already locked against <17.5 in version check, though this could replace that too :) Also deja-vu