IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
569 stars 162 forks source link

[Combo] Make FilteringOptions.caseSensitive optional, revert filterable migration for now #14339

Closed damyanpetev closed 3 months ago

damyanpetev commented 3 months ago

Reverts migration added in #14323 because it caused errors and I'm not sure that property is even done right. Still making the caseSensitive optional since it's a false-default bool that can just as easily be omitted when typing other options, just for ease of configuration.

As for the filterable option - not really sure it's done right like that. For one, it's pretty odd to have to explicitly set true when you're already providing filtering options and it's more/less implied you want filtering. Also, pretty hard to find a use case for it in the spec. It's implemented separately at least as disableFiltering in WC, though that spec or the design handoff also don't discuss use cases for it. At the very least - we should clear up that and also the options handling should probably merge setting w/ defaults, see WC implementation.

Additional information (check all that apply):

Checklist: