Open MonikaKirkova opened 1 week ago
@sdimchevski With this PR in igniteui-angular
we are always making filtering available and removing the option to enable/disable it. This is a little bit different from what is in igniteui-webcomponents
, where we have the disableFiltering
option available.
You can see that in angular sample, disabling the filter will not remove the search input, just will stop the filtering and reduce the list. While in the webcomponent sample when filtering is disabled, then the search input is removed.
On one hand, we want to have consistency between different platforms. On the other hand disabling the filtering may not be a common scenario, but would appreciate any design input from you on the matter.
@sdimchevski With this PR in
igniteui-angular
we are always making filtering available and removing the option to enable/disable it. This is a little bit different from what is inigniteui-webcomponents
, where we have thedisableFiltering
option available.You can see that in angular sample, disabling the filter will not remove the search input, just will stop the filtering and reduce the list. While in the webcomponent sample when filtering is disabled, then the search input is removed.
On one hand, we want to have consistency between different platforms. On the other hand disabling the filtering may not be a common scenario, but would appreciate any design input from you on the matter.
@Lipata @kdinev From a UX point of view, right now in Angular it’s not OK and is confusing to set filtering disabled and still have the search option. The behavior in Angular is actually the same as in Web components, once you switch off the Allow Custom Values feature (there is no such feature in WebC at the moment). So instead of removing the option to enable/disable the filtering in Angular, when we have the filtering disabled and the Allow Custom Values enabled, why don't we change the Placeholder from Search to Add Item?
@sdimchevski With this PR in
igniteui-angular
we are always making filtering available and removing the option to enable/disable it. This is a little bit different from what is inigniteui-webcomponents
, where we have thedisableFiltering
option available. You can see that in angular sample, disabling the filter will not remove the search input, just will stop the filtering and reduce the list. While in the webcomponent sample when filtering is disabled, then the search input is removed. On one hand, we want to have consistency between different platforms. On the other hand disabling the filtering may not be a common scenario, but would appreciate any design input from you on the matter.@Lipata @kdinev From a UX point of view, right now in Angular it’s not OK and is confusing to set filtering disabled and still have the search option. The behavior in Angular is actually the same as in Web components, once you switch off the Allow Custom Values feature (there is no such feature in WebC at the moment). So instead of removing the option to enable/disable the filtering in Angular, when we have the filtering disabled and the Allow Custom Values enabled, why don't we change the Placeholder from Search to Add Item?
I agree with your suggestion and if the placeholder displays the correct prompt, then I'm OK.
Closes #14340
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)