IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
568 stars 159 forks source link

Remove filterable property #14408

Open MonikaKirkova opened 1 week ago

MonikaKirkova commented 1 week ago

Closes #14340

Additional information (check all that apply):

Checklist:

Lipata commented 1 week ago

@sdimchevski With this PR in igniteui-angular we are always making filtering available and removing the option to enable/disable it. This is a little bit different from what is in igniteui-webcomponents, where we have the disableFiltering option available.

You can see that in angular sample, disabling the filter will not remove the search input, just will stop the filtering and reduce the list. While in the webcomponent sample when filtering is disabled, then the search input is removed.

On one hand, we want to have consistency between different platforms. On the other hand disabling the filtering may not be a common scenario, but would appreciate any design input from you on the matter.

sdimchevski commented 4 days ago

@sdimchevski With this PR in igniteui-angular we are always making filtering available and removing the option to enable/disable it. This is a little bit different from what is in igniteui-webcomponents, where we have the disableFiltering option available.

You can see that in angular sample, disabling the filter will not remove the search input, just will stop the filtering and reduce the list. While in the webcomponent sample when filtering is disabled, then the search input is removed.

On one hand, we want to have consistency between different platforms. On the other hand disabling the filtering may not be a common scenario, but would appreciate any design input from you on the matter.

@Lipata @kdinev From a UX point of view, right now in Angular it’s not OK and is confusing to set filtering disabled and still have the search option. The behavior in Angular is actually the same as in Web components, once you switch off the Allow Custom Values feature (there is no such feature in WebC at the moment). So instead of removing the option to enable/disable the filtering in Angular, when we have the filtering disabled and the Allow Custom Values enabled, why don't we change the Placeholder from Search to Add Item?

kdinev commented 3 days ago

@sdimchevski With this PR in igniteui-angular we are always making filtering available and removing the option to enable/disable it. This is a little bit different from what is in igniteui-webcomponents, where we have the disableFiltering option available. You can see that in angular sample, disabling the filter will not remove the search input, just will stop the filtering and reduce the list. While in the webcomponent sample when filtering is disabled, then the search input is removed. On one hand, we want to have consistency between different platforms. On the other hand disabling the filtering may not be a common scenario, but would appreciate any design input from you on the matter.

@Lipata @kdinev From a UX point of view, right now in Angular it’s not OK and is confusing to set filtering disabled and still have the search option. The behavior in Angular is actually the same as in Web components, once you switch off the Allow Custom Values feature (there is no such feature in WebC at the moment). So instead of removing the option to enable/disable the filtering in Angular, when we have the filtering disabled and the Allow Custom Values enabled, why don't we change the Placeholder from Search to Add Item?

I agree with your suggestion and if the placeholder displays the correct prompt, then I'm OK.