Adding default overlay settings

IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.

https://www.infragistics.com/products/ignite-ui-angular

Other

569 stars 162 forks source link

Adding default overlay settings #14459

Closed IvanKitanov17 closed 3 months ago

IvanKitanov17 commented 3 months ago

Closes #14297

Additional information (check all that apply):

[x] Bug fix
[ ] New functionality
[ ] Documentation
[ ] Demos
[ ] CI/CD

Checklist:

[ ] All relevant tags have been applied to this PR
[ ] This PR includes unit tests covering all the new code (test guidelines)
[ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
[ ] This PR includes feature/README.MD updates for the feature docs
[ ] This PR includes general feature table updates in the root README.MD
[ ] This PR includes CHANGELOG.MD updates for newly added functionality
[ ] This PR contains breaking changes
[ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
[ ] This PR includes behavioral changes and the feature specification has been updated with them

mddragnev commented 1 month ago

@ChronosSF @wnvko @IvanKitanov17 This is not fixing the mentioned bug https://github.com/IgniteUI/igniteui-angular/issues/14297 . This is only introducing default overlay settings without a target. A target is needed so that the toggle can look up to the sizing (which should come from the target element). This is somehow related to: https://github.com/IgniteUI/igniteui-angular/issues/14618 because it was regressed back when we removed the Display density. Could you please take a look at this again?

wnvko commented 1 month ago

@mddragnev

This PR actually fixes the missing default overlay settings for the drop-down. Looking at this issue #14297 I am not sure what should be fixed. Can anyone log a new issue with steps to reproduce, what exactly is not working and what expected result should be.

mddragnev commented 1 month ago

@wnvko Nevermind, I fixed the issue some other way. The problem with the default settings was that there is no target. However, I created a PR https://github.com/IgniteUI/igniteui-angular/pull/14634 if you please look at it since it is some work on toggle and dropdown.