IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
571 stars 162 forks source link

[Igx-navbar] The icon buttons' color doesn't match the title text color when changing to the material dark theme #14599

Closed PlamenD95 closed 1 month ago

PlamenD95 commented 3 months ago

Description

When using the material dark theme, the color of the icon buttons doesn't match the black color of the title text for the navigation bar:

image

The correct color is properly assigned to the igx-navbar css class:

image

However, it gets overwritten by the igx-icon-button class for the icon buttons:

image

Steps to reproduce

  1. Add the igx-navbar component in an application
  2. Use the material dark theme.

Result

There is a mismatch between the colors of the icon buttons and the title text of the navigation bar. The icon buttons are white, while the title text is black,

Expected result

Both the icon buttons and the title text should be black.

simeonoff commented 3 months ago

@PlamenD95 17.2.0 is no longer supported, however, the issue is still (partially) reproducible in 18.1.0.

sdimchevski commented 2 months ago

I've discussed this issue with the Design team and we've worked on a solution. The problems that we have with the icon buttons in the Navbar are in Material and Indigo. What we propose is not to change the icon buttons in the context of the Navbar but change the Navbar styling instead. The changes are discussed with @simeonoff and @andiesm813 as well.

@kdinev To keep the icon buttons styling (flat, outlined and contained) intact, these are the changes that we want to make:

Material:

material-navbar

Indigo:

indigo-navbar

Here are a few design patterns, showcasing the applied changes in

Material

Screenshot 2024-08-20 at 15 09 42

Indigo

Screenshot 2024-08-20 at 15 11 50
kdinev commented 2 months ago

@sdimchevski Looks good to me!