IgniteUI / igniteui-angular

Ignite UI for Angular is a complete library of Angular-native, Material-based Angular UI components with the fastest grids and charts, Pivot Grid, Dock Manager, Hierarchical Grid, and more.
https://www.infragistics.com/products/ignite-ui-angular
Other
572 stars 161 forks source link

QueryBuilder: Changes in edited condition are committed when start editing another #14881

Closed teodosiah closed 1 day ago

teodosiah commented 1 month ago

Description

When we change the currently edited condition without committing or discarding it, it is committed.

QB_issue9

Steps to reproduce

  1. Start editing a condition
  2. Without committing/discarding it click on another condition in order to enter edit mode

Result

The previously edited condition is committed

Expected result

Instead of committing it, wouldn't it be better to discard the change (since it is not explicitly committed) or prevent entering edit mode if the change in the edited condition is not committed or discarded?

teodosiah commented 1 month ago

After discussing the behavior with @sdimchevski, we have decided that if we change the edited condition, it should be discarded.

teodosiah commented 1 week ago

@sdimchevski After further investigation, I have determined that the same behavior is observed in the Grid Row Editing, i.e. the changed cell value is committed when clicking in another row. rowediting Considering this, should we change the Query Builder behavior or keep it this way?

sdimchevski commented 2 days ago

@teodosiah OK, it's not optimal but let's keep it this way in the Query Builder because I don't want to change the behavior in the grid now.