Closed ChronosSF closed 4 years ago
As much as I like the smart import - indeed it might be a bit of a stretch.
And we'll need start describing which components need the HammerModule
. Actually, we might need to start doing that anyway for both user documentation and meta info for tooling.
Considering we already include the hammer script on project setup (ng add
or Ignite UI CLi project) seems kind of a miss to not import the module as well. I guess it can be prompt-y, though don't remember if I've seen migrations with prompts.
If certain modules cannot function without hammer, then hammer should be made a dependency.
@kdinev Not an option unfortunately..
Must be imported at root (see https://github.com/angular/angular/pull/32203) since it adds an event plugin and those are only loaded once for the platform.
It's basically like BrowserAnimationsModule
.
Description
With Angular 9 components such as the igxSlider won't work in user apps unless the HammerModule is imported on root level.
To prevent users from encountering issues with our Hammer-dependant components we have 3 options (ordered by complexity):
(or we can always get rid of our hammer dependency :) )
Steps to reproduce
Result
Dragging doesn't work until you include the HammerModule from @angular/platform-browser in the app root module.