search

IgniteUI / igniteui-cli

Ignite UI Command-Line Interface by Infragistics
https://bit.ly/2L19rhp
MIT License
118 stars 4 forks source link

Update CLI's eslint config and consider marking template files as .template #1236

Open jackofdiamond5 opened 6 months ago

jackofdiamond5 commented 6 months ago

Description

Dependent on #1294

After https://github.com/IgniteUI/igniteui-cli/pull/1235 we now have eslint as our linter. At the moment it needs a bit configuring, namely we want to use the @typescript-eslint/recommended features so that we are sure we are on the right track in terms of code quality. This change, however, is bound to introduce a need for refactoring as some rules that we may prefer to keep can outline mistakes in our code style. As such this change should be considered alongside the CLI's update to newer packages (like inquirer, jasmine, etc.). We must also make sure that we remove any and all remaining tslint references and to generally clear any/all lint errors in the CLI.

Additionally, as proposed by @damyanpetev, we may want to make sure that the names of all files that we consider templates end in .template. This can prevent issues with runtimes such as eslint that look for specific file configurations and execute some logic after finding these files. This logic can conflict with our templates or can cause the runtime to fail/throw altogether. Such a problem was discovered in the aforementioned issue.

As a side note, we may want to consider using biome instead of eslint, but further research is needed.

github-actions[bot] commented 2 months ago

There has been no recent activity and this issue has been marked inactive.