IgniteUI / igniteui-webcomponents

Ignite UI for Web Components is a complete library of UI components, giving you the ability to build modern web applications using encapsulation and the concept of reusable components in a dependency-free approach.
https://www.infragistics.com/products/ignite-ui-web-components
Other
113 stars 2 forks source link

feat(dropdown): update indigo styles #1189

Closed SisIvanova closed 1 month ago

SisIvanova commented 2 months ago

Related to https://github.com/IgniteUI/igniteui-theming/issues/234

didimmova commented 1 month ago
didimmova commented 1 month ago

I think the outline of the active item should have outline-offset like in the angular PR

andiesm813 commented 1 month ago

@SisIvanova i couldnt run these either.... image

andiesm813 commented 1 month ago

I think the outline of the active item should have outline-offset like in the angular PR

When you say "active" i assume it's focused.... if so, and if what you mean about the offset is that it's outlined center or outside the element, we actually have inside border.

image

AnjiManova commented 1 month ago
AnjiManova commented 1 month ago

The overline style is wrong. A merged PR with the overline style is available, but the change is not visible in this PR.

AnjiManova commented 1 month ago
AnjiManova commented 1 month ago
AnjiManova commented 1 month ago
AnjiManova commented 1 month ago

The code is not from WebC but there is the same issue so I duplicate the comment from Angular

image
AnjiManova commented 1 month ago
SisIvanova commented 1 month ago
  • the border radius should be fixed or something not sure what is the problem here
image

This issue is not related to the Indigo design updates and will be fixed in a separate PR.

SisIvanova commented 1 month ago

The overline style is wrong. A merged PR with the overline style is available, but the change is not visible in this PR.

I believe the font styles are correct.

Screenshot 2024-05-27 at 11 40 10 AM
sdimchevski commented 1 month ago

I think we are ready with the verification. @andiesm813 do you have something to add because I want to change the label to design:verified

andiesm813 commented 1 month ago

@SisIvanova i couldnt run these either.... image

I am still not able to run this branch (since 2 weeks ago)..... @SisIvanova i cannot verify or add anything else. Anji reviewed this thoroughly and i'm sure she didnt miss anything. So we can mark it as verified if you want @sdimchevski

SisIvanova commented 1 month ago

I am still not able to run this branch (since 2 weeks ago)..... @SisIvanova i cannot verify or add anything else. Anji reviewed this thoroughly and i'm sure she didnt miss anything. So we can mark it as verified if you want @sdimchevski

You couldn't run the samples because of the theming package version. Simeon created a new PR including the Indigo design changes for the dropdown, progress, and list components. You should be able to test it without any difficulty.

andiesm813 commented 1 month ago

@SisIvanova yes! Didi told me as well! i was able to test it now! The only thing i see weird is the Web Components version, it has like a white background color and then inside the actual dropdown appears, with the rounded corners.... In Angular it looks ok.

image

These corners i mean

image

SisIvanova commented 1 month ago

@SisIvanova yes! Didi told me as well! i was able to test it now! The only thing i see weird is the Web Components version, it has like a white background color and then inside the actual dropdown appears, with the rounded corners.... In Angular it looks ok.

image

These corners i mean

image

This problem is reproducible in all themes and will be fixed in a separate PR. I will log a new issue.