Closed SisIvanova closed 1 month ago
I think the outline of the active item should have outline-offset like in the angular PR
@SisIvanova i couldnt run these either....
I think the outline of the active item should have outline-offset like in the angular PR
When you say "active" i assume it's focused.... if so, and if what you mean about the offset is that it's outlined center or outside the element, we actually have inside border.
The overline style is wrong. A merged PR with the overline style is available, but the change is not visible in this PR.
The code is not from WebC but there is the same issue so I duplicate the comment from Angular
- the border radius should be fixed or something not sure what is the problem here
This issue is not related to the Indigo design updates and will be fixed in a separate PR.
The overline style is wrong. A merged PR with the overline style is available, but the change is not visible in this PR.
I believe the font styles are correct.
I think we are ready with the verification. @andiesm813 do you have something to add because I want to change the label to design:verified
@SisIvanova i couldnt run these either....
I am still not able to run this branch (since 2 weeks ago)..... @SisIvanova i cannot verify or add anything else. Anji reviewed this thoroughly and i'm sure she didnt miss anything. So we can mark it as verified if you want @sdimchevski
I am still not able to run this branch (since 2 weeks ago)..... @SisIvanova i cannot verify or add anything else. Anji reviewed this thoroughly and i'm sure she didnt miss anything. So we can mark it as verified if you want @sdimchevski
You couldn't run the samples because of the theming package version. Simeon created a new PR including the Indigo design changes for the dropdown, progress, and list components. You should be able to test it without any difficulty.
@SisIvanova yes! Didi told me as well! i was able to test it now! The only thing i see weird is the Web Components version, it has like a white background color and then inside the actual dropdown appears, with the rounded corners.... In Angular it looks ok.
These corners i mean
@SisIvanova yes! Didi told me as well! i was able to test it now! The only thing i see weird is the Web Components version, it has like a white background color and then inside the actual dropdown appears, with the rounded corners.... In Angular it looks ok.
These corners i mean
This problem is reproducible in all themes and will be fixed in a separate PR. I will log a new issue.
Related to https://github.com/IgniteUI/igniteui-theming/issues/234