search

IgniteUI / igniteui-webcomponents

Ignite UI for Web Components is a complete library of UI components, giving you the ability to build modern web applications using encapsulation and the concept of reusable components in a dependency-free approach.
https://www.infragistics.com/products/ignite-ui-web-components
Other
113 stars 2 forks source link

Slider: Theme Issues #1213

Closed simeonoff closed 1 month ago

simeonoff commented 1 month ago
  1. The track should have 4px radius
  2. The tickmarks should start right under the end of the track. Screenshot 2024-05-15 at 14 29 34

3.Тhe "Discrete Regions" should start from 0 as in the Handoff

Screenshot 2024-05-15 at 17 11 34

  1. The focus border of the thumb should be 3px

  2. Тhe triangle of the label tooltip should have 12px height @andiesm813 please, check the comments and also, please check the behaviour of the Hover and Focus states - whether each element should have these states separately or when on Hover or Focused the whole component should be in that state.

Originally posted by @sbayreva in https://github.com/IgniteUI/igniteui-webcomponents/issues/1134#issuecomment-2112293500

Comment from Andie:

@sbayreva All your comments (1-4) are good. About https://github.com/IgniteUI/igniteui-webcomponents/issues/1 (radius of the track), it was also not implemented in Angular (from what i'm seeing).

About the hover and focus states, the current behavior in WC is the same as in the Angular component. Track and track base do hover together, but the thumb hovers separately, only when hovered on the thumb. So IMO it's all good as implemented now.

didimmova commented 1 month ago

@sdimchevski @andiesm813 We discussed that the slider ticks and thumb are positioned correctly the way they're positioned now. Also having steps on 0 and 100 IMO are unnecessary but if you insist on having them, it's for a different issue, that would probably not be handled by our team.