search

IgniteUI / igniteui-webcomponents

Ignite UI for Web Components is a complete library of UI components, giving you the ability to build modern web applications using encapsulation and the concept of reusable components in a dependency-free approach.
https://www.infragistics.com/products/ignite-ui-web-components
Other
113 stars 2 forks source link

Indigo Themes: Updates to Toast, Stepper, Rating #1249

Closed simeonoff closed 14 hours ago

AnjiManova commented 1 week ago

Rating

The label padding should be 2px, not 4px. The right padding of the symbols should be removed. There are sizes for the symbols provided in the kit, which are - small -18x18;
medium - 24x24 (default one) @andiesm813 confirm this pleases; and
large - 30x30 (mentioning them because in Angular they are not the same) The row gap should be 4px, not 5px.

AnjiManova commented 1 week ago

Toast

The component's minimum width doesn't come from us. For now, 3.25rem works well, but in the future, some changes might be suggested from our side.

The border is now outside the component, which causes it to be different in height from the one in the kit. ✅ implemented

andiesm813 commented 1 week ago

Rating

The label padding should be 2px, not 4px. The right padding of the symbols should be removed. There are sizes for the symbols provided in the kit, which are - small -18x18;
medium - 24x24 (default one) @andiesm813 confirm this pleases; and
large - 30x30 (mentioning them because in Angular they are not the same) The row gap should be 4px, not 5px.

RATING looks good to me @AnjiManova, the symbols sizes that is. The rest of the component looks good! ✅

andiesm813 commented 1 week ago

TOAST Looking good! ;) ✅

andiesm813 commented 6 days ago

STEPPER It looks fine to me... Except for the "content" part, that should have more padding.... but since that's in a slot, it's not something we control, correct?

image

desig9stein commented 6 days ago

STEPPER It looks fine to me... Except for the "content" part, that should have more padding.... but since that's in a slot, it's not something we control, correct?

image

We can, I change it to 16px as it is in the UI kit

AnjiManova commented 5 days ago

Stepper

Light & Dark Mode

desig9stein commented 5 days ago

Stepper

  • Min-height of the vertical lines should be 24px
  • Min-width of the horizontal lines should be 40px

Light & Dark Mode

  • Invalid state - the subtitle text color should be grays.700 and should uses other var I guess
image

@AnjiManova For the min-height of the vertical separator we should create another issue since it is not a mater of just fixing the theme, it requires changes in the component animation.

AnjiManova commented 4 days ago

Stepper

  • Min-height of the vertical lines should be 24px
  • Min-width of the horizontal lines should be 40px

Light & Dark Mode

  • Invalid state - the subtitle text color should be grays.700 and should uses other var I guess
image

@AnjiManova For the min-height of the vertical separator we should create another issue since it is not a mater of just fixing the theme, it requires changes in the component animation.

Agreed, a new issue to be then.