IgnitionModuleDevelopmentCommunity / IgnitionNode-RED

Adds support for Node-RED
Apache License 2.0
31 stars 7 forks source link

Fix websockets functionality for Ignition 8.1.25+ #35

Closed thirdgen88 closed 1 year ago

thirdgen88 commented 1 year ago

⚙️ Summary

This PR applies one more fix to those from #32 related to how the websocket channel is setup. With Jetty 9, we called both a register and a setCreator method in order to configure the websocket creation. With Jetty 10, invoking that register method seems to take precedence over our prescribed creator and drive use of a no-arg constructor for the class instead. Removing that register call is all that is needed.

☑️ QA Notes

Prior to this change, I was getting errors in Ignition logs when attempting to use the ignition tag read ws node in Node-RED to connect to the gateway. With this change, I was able to start receiving values on-change within Node-RED without any issues.

Fixes #34