Ignitus / Ignitus-client

Ignitus-client architecture . ☘️
http://www.ignitus.org
84 stars 118 forks source link

Migration prop-Types => TS ★ #477

Closed divyanshu-rawat closed 4 years ago

divyanshu-rawat commented 4 years ago

Is your feature request related to a problem? Please describe. We also plan to migrate our Type checking capabilities to TS.

Describe the solution you'd like Migration to TS ★

Describe alternatives you've considered Flow seems good but still TS offer more capabilities.

Additional context https://www.typescriptlang.org/

So, I am adding RGSoC label to this issue as well, everyone can independently work on migration of components and please when you take up this issue then let us know via commenting that which component you are planning to migrate, if not a component them which files. ;) If you have further Questions ping me anytime in Ignitus/GSSOC slack.

Here are the list of components that are migrated till so far to TypeScript in mentioned pull request. https://github.com/Ignitus/Ignitus-client/pull/524

1 - ignitus-About 2 - ignitus-Contributors 3 - ignitus-CoreTeam 4 - ignitus-Partners 5 - ignitus-Team

and some other files. cc @debck , @gittysachin please keep this in mind, and we will keep on updating this issue as more and more components keep on migrating 👍

github-actions[bot] commented 4 years ago

Stale issue message

divyanshu-rawat commented 4 years ago

1st step is to convert any file to TS file, and then replicate the same for other files as well 👍

steric85 commented 4 years ago

Hey! I am a GSSoC'20 participant. I'd like to work on this.

divyanshu-rawat commented 4 years ago

sure go ahead 👍 , #524 does migration from some components, feel free to pick some other component, or wait until tom. I will compile here a list of components that I think are in need of migration :)

steric85 commented 4 years ago

Sure, thanks a lot!

steric85 commented 4 years ago

Hey @divyanshu-rawat I started with the common-auth-student-prof folder. Could you please review the changes in #548 to know if I'm going in the right direction?

divyanshu-rawat commented 4 years ago

Sure will do thanks :) 😊

divyanshu-rawat commented 4 years ago

once @steric85 is done migrating some components, then we are taking this issue out of gssoc20 to rgsoc20.

toshihidetagami commented 4 years ago

Hi! This is cool project so I want to take part. I picked ignitus-Introduction and just made a pull request.

divyanshu-rawat commented 4 years ago

Thanks @toshihidetagami for your Interest, you can also join our slack if you are interested to contribute further :).

toshihidetagami commented 4 years ago

@divyanshu-rawat Thanks for the invitation. I will definitely join!

aysp-99 commented 4 years ago

Hi! I'd like to work on ignitus-GetStarted folder. But GSSoC label was removed so can I still work on it?

gittysachin commented 4 years ago

@aysp-99 you can check other issues that have GSSoC labeled issues. We've specifically labeled this issue for RGSoC participants. Thanks :)

divyanshu-rawat commented 4 years ago

@aysp-99 you can go ahead 👍 , @gittysachin the problem is that new all the new PRS, that we have merged have JS written on them instead of TS leaving lot of work for migration, so even if @aysp-99 will work on migrating some components new contributors will add more JS files which Implies we always have to migrate to TS leaving migration to TS as IN-PROGRESS task always, nevertheless after sometime we will change our contribution guidelines that we will accept PRS written in TS only.

aysp-99 commented 4 years ago

Sure. Thanks :)

gittysachin commented 4 years ago

Thanks @divyanshu-rawat, I'll keep that in mind. @aysp-99 please go ahead :+1:

aysp-99 commented 4 years ago

Can I work on testimonial component or any other component that you'd suggest me to work on?

Paarmita commented 4 years ago

@aysp-99 We want to change the UI for testimonials, so if you want to migrate the component then you also need to change the UI, are you willing to work on that as well?

aysp-99 commented 4 years ago

@Paarmita Yes, Sure. I shall do that. :)

Paarmita commented 4 years ago

@aysp-99 Okay, I will assign you the issue.

Marvin9 commented 4 years ago

Migration is completed in v6.2.0 🎉 Can we close this one?