Panel bar is not aligned

[jpfleury]

Note: this is a copy of the ticket 5797 on the SourceForge tracker.

With SpaceFM 0.6.0, the new panel bar to the right of the menu bar doesn't seem to be aligned, either left, center or right. It seems to be just a little bit lost in the interface:

• not aligned to the right of the menu bar, or
• not aligned to the very right of the SpaceFM window, or
• not centered in the free space between the menu bar and the right edge of the SpaceFM window, or
• not aligned to the center of the SpaceFM window.

[jpfleury]

Note: this is a copy of a comment from IgnorantGuru.

If possible, please provide a screenshot of what you're seeing, thanks.

[jpfleury]

Note: this is a copy of a comment from jpfleury.

Here's a screenshot.

[jpfleury]

Note: this is a copy of a comment from linuxdirk.

I can confirm this bug. Same view for me.

[BwackNinja]

Fixed with: https://github.com/BwackNinja/spacefm/commit/4eba523b24da4318e49a60b333f4bcd6168c29b0

[IgnorantGuru]

Thanks for taking a look at this, but I don't want the panel bar at the far right. The idea of putting it toward the middle was to keep it away from the window's close/maximize buttons, in an area where not much else is going on.

But it would be nice to position it maybe at 75% of window width instead of floating, and I'd like to address the color change which occurs in many themes from the left of the panel bar to the right of it. I worked on this for awhile without much luck.

[BwackNinja]

Right aligning it would make sense on Ubuntu systems, at least in their default configuration. The only way I can think of getting it to stay at ~75% of the window width would be putting the menubar and panel bar in a GtkFixed and manually handling the resizes. Regardless, I don't know how consistent aligning the panel bar to anywhere other than the right or left would look.

[IgnorantGuru]

I don't mind the position - seems to be centered between the end of the menu items and the right side of the window. I more would like to avoid the color difference to the right and left of it (only affects some themes, particularly noticeable in dark ones).

[BwackNinja]

The color difference should be fixed with gtk3 in https://github.com/BwackNinja/spacefm/commit/e580b9dbb7a019b934ec2a5ce6f9cb03dc6d283e. I haven't looked at fixing that for gtk2, but that should be simple.

[IgnorantGuru]

Doesn't seem to be - I still have the same light-gray on one side and dark gray on the other.

[BwackNinja]

Odd, screenshot?

[IgnorantGuru]

http://en.zimagez.com/zimage/screenshot-spacefm-panelbar.php

That's with DarkMint

[BwackNinja]

And now that's fixed with: https://github.com/BwackNinja/spacefm/commit/65ab4dca326e96fe349a4f05b94adf5b0b17a38f

[IgnorantGuru]

Thanks that does correct the background. Somehow it broke the square shape of the unselected toolbar buttons (screenshot) but I don't think that matters - looks much better.

Any prospect for a gtk2 version of this fix?

[BwackNinja]

The panel bar is no longer seen by the theme system as a toolbar, but as a menubar. The buttons were themed with a square shape around them by the your theme, specifically if they're on a toolbar, not a menubar. To do anything about that, it would have to be a change in the theme.

I've tried to do a gtk2 equivalent of this fix, but I haven't had any luck yet. I can kind of see why the gtk devs decided it was worth losing compatibility with every gtk2 theme to have a much more flexible theming system. I just wish they would stop breaking theme compatibility with every release.

[IgnorantGuru]

Probably nothing further will be done with this for gtk2, but it does now appear to be aligned in gtk2.