IgnorantGuru / spacefm

SpaceFM File Manager
http://ignorantguru.github.com/spacefm/
GNU General Public License v3.0
489 stars 73 forks source link

FTBFS with enable hal in build #363

Closed mati75 closed 11 years ago

mati75 commented 11 years ago

I get FTBFS on Debian unstable:

oom:  g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_NOMEM, g_strerror (ENOMEM));
 ^
../../../src/vfs/vfs-volume-hal.c: In function 'vfs_volume_hal_mount':
../../../src/vfs/vfs-volume-hal.c:2529:1: error: format not a string literal and no format arguments [-Werror=format-security]
 oom:      g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_NOMEM, g_strerror (ENOMEM));
 ^
../../../src/vfs/vfs-volume-hal.c: In function 'vfs_volume_hal_unmount':
../../../src/vfs/vfs-volume-hal.c:2764:1: error: format not a string literal and no format arguments [-Werror=format-security]
 oom:  g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_NOMEM, g_strerror (ENOMEM));
 ^
../../../src/vfs/vfs-volume-hal.c: In function 'vfs_volume_mount_by_udi_as_root':
../../../src/vfs/vfs-volume-hal.c:2889:13: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
     argv[1] = g_get_prgname();
             ^
../../../src/vfs/vfs-volume-hal.c: In function 'vfs_volume_umount_by_udi_as_root':
../../../src/vfs/vfs-volume-hal.c:2909:13: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
     argv[1] = g_get_prgname();
             ^
../../../src/vfs/vfs-volume-hal.c: In function 'vfs_volume_eject_by_udi_as_root':
../../../src/vfs/vfs-volume-hal.c:2927:13: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
     argv[1] = g_get_prgname();
             ^
cc1: some warnings being treated as errors
make[3]: *** [spacefm-vfs-volume-hal.o] Error 1
make[3]: Leaving directory `/tmp/buildd/spacefm-0.8.7/debian/build-gtk2/src'
make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/spacefm-0.8.7/debian/build-gtk2'
dh_auto_install: make -j1 install DESTDIR=/tmp/buildd/spacefm-0.8.7/debian/tmp/gtk2 AM_UPDATE_INFO_DIR=no returned exit code 2
make[1]: *** [doinstall-gtk2] Error 2
make[1]: Leaving directory `/tmp/buildd/spacefm-0.8.7'
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
E: Failed autobuilding of package
I: unmounting dev/pts filesystem
I: unmounting run/shm filesystem
I: unmounting proc filesystem
I: cleaning the build env 
I: removing directory /var/cache/pbuilder/build//23496 and its subdirectories
IgnorantGuru commented 11 years ago

Thanks for the report. I believe these warnings have already been addressed in the 'next' branch, due for 0.9.0 release. You can test by following the BUILD NEXT instructions in README. If any critical warnings remain in that branch please detail. If you really want 0.8.7, you'll just need to turn off the warnings-as-errors compile flags. Also note that there are now official 0.8.7 packages offered by debian.

IgnorantGuru commented 11 years ago

n/m there are still some problems with warnings in next on the hal build... standby for a commit.