IgnorantGuru / spacefm

SpaceFM File Manager
http://ignorantguru.github.com/spacefm/
GNU General Public License v3.0
487 stars 73 forks source link

1.0.2 regression: Dbl-click to enter dir in Icon/Compact styles selects file under cursor #702

Closed IgnorantGuru closed 6 years ago

IgnorantGuru commented 6 years ago

Release 1.0.2 708f0988 corrected a problem in Icon & Compact list styles, with option 'Single click opens files' disabled, where a left-click on a file did not always unselect other files. However, this change introduced a problem where double-clicking to enter a directory selects the file under the cursor in the entered directory, unselecting history in that directory. Due to timing, these affects may also vary due to the size of the directories involved.

The latest fix for this issue has been pushed to next and alpha, due for 1.0.6 release. Because changes in this area of the code sometimes cause regressions, testing is recommended (assorted mouse functions in assorted list styles, with and without option 'Single click opens files' enabled).

Technical details: Code in ptk-file-browser.c:on_folder_view_button_release_event() was made non-conditional on app_settings.single_click in 1.0.2 708f0988 because it caused a left-click to not unselect other files. However, this caused file under cursor to be selected when entering directory by double-click in Icon/Compact styles, due to the button release on the last click (of the double-click) being handled after the dir changed. To correct this, 1.0.6 conditionally sets skip_release on GDK_2BUTTON_PRESS, and conditionally doesn't reset skip_release in ptk_file_browser_chdir().