IgnorantGuru / spacefm

SpaceFM File Manager
http://ignorantguru.github.com/spacefm/
GNU General Public License v3.0
489 stars 73 forks source link

Text alignment issue from Icons View #782

Open ghost opened 4 years ago

ghost commented 4 years ago

Long time spacefm GTK2 user as soon as i switched to spacefm-gtk3 recently i noticed text alignment issue on Icons View

Some images filenames suffer bad alignment text to icons. I am showing it with the picture below

Icons View BAD! Compact View OK! Detailed View OK!

If it looked closely the file name on the 1rst pic **2020-09-04-160521_1600x900_scrot.png** show up with an extra dash "-" like **2020-09-04-160521_1600x90-0_scrot.png** the extra dash does not exist if hit F2 or if you check the Compact/Detailed. If i rename the filename alignment fixed. Not every "JPG" or "PNG" happens like that, from my collections many filenames are OK many others aren't.

Perhaps i miss a package? or i'm not sure if it's a bug.

Im using:

Devuan GNU/Linux 4 (chimaera/ceres) x86_64
SpaceFM-gtk3 1.0.6-5
ghost commented 4 years ago

This seems a font issue, checking the closed issues reached #206 As soon as i changed the font everything was fixed. I'm using font Sarasa-Gothic exactly "sarasa-term-hc-semibold.ttf"

I use this font for almost everything on my system, but only on spacefm/Icons view i see this concern. I'm not sure it is a font issue or spacefm-gtk3? because as i said above from compact view or detailed seems so fine.

EDIT: I spoke too soon, in fact changing the font fixes the situation, but as soon as i made a new printscreen via scrot, or making a new directory with a few "-" dash the alignment issue appears again even to another font selected.

Perhaps this old "text wrapping" may have turned back on GTK3? https://github.com/IgnorantGuru/spacefm/issues/206#issuecomment-11513167

GTK3 is very irritating, despite the fact that there are many positive things versus GTK2 currently i have a few other minor glitches on spacefm-gtk3, but i'm not going to report for now by the non-solid nature of API or GTK3-Themes or due to bugs on my testing system. I must first identify if the glitches are my concerns, my-testing-system or spacefm-gtk3 ends.

So far i'm happy with VIEW/STYLE/COMPACT or VIEW/STYLE/DETAILED i see no fonts glitches or other issues on those particular selections.

BwackNinja commented 3 years ago

This problem is new and doesn't come from GTK3; it comes from pango 1.44 and newer, which does auto-hyphenation by default.

https://gitlab.gnome.org/GNOME/pango/-/issues/401#note_636509

ghost commented 3 years ago

Thanks so much for locate it BwackNinja, I probably would not find it myself. This extra dash bothered me somewhat, meanwhile i still have font align issue like ghost have encountered years ago. I doubt that old issue has come again in GTK3 this time.

I have tested with different GTK3 themes from: https://www.gnome-look.org/browse/cat/135/order/latest/ Also more updated ones with Adwaita (master) https://gitlab.gnome.org/GNOME/gtk/tree/master/gtk/theme/Adwaita Also tested with many Noto Fonts (latest from Debian repo) any font changes constantly i made temporarily seems a fix, but not in all files or directories.

Other glitch found is a line fade from right to bottom (see link below), i thought could be a theme issues at first due to GTK3 nature, but all GTK3 themes i tried those fade won't go on Icons Window. Edit here: Please see the attach

The only theme that fixed those fade is DarK by sixsixfive https://gitlab.com/sixsixfive/DarK/-/tree/master/DarK/gtk-3.0 I think he may added some extra border around the gui or made all fades hide somehow.

Also, thanks to this thread i managed to stop those dotted fade that won't go on Icons Window. https://forum.mxlinux.org/viewtopic.php?t=44897 Positively i have created a gtk.css to $HOME/.config/gtk-3.0 and added those code

background-image: none;
}

overshoot.bottom {
background-image: none;
}

overshoot.left {
background-image: none;
}

overshoot.right {
background-image: none;
}

I call solved the fade, but i'm not sure where the issue lies on GTK3 or spacefm Icons Window? It's very strange but all those glitches appears only on View > Styles > Icons. Run spacefm from terminal not report back any errors.

Tested on OS: Debian/Devuan testing WM: CWM currently, but used too many from Openbox/Fluxbox/DWM/SpectrWM etc... No issue from WM side. Fonts: Iosevka or Noto

If there will be new fix from pango regarding that extra dash i'll confirm back. Thanks for your check.

P.S. Sorry to open two or three issues on the same ticket.