Replace use of get_file() with download_file()

IgnoredAmbience / yahoo-group-archiver

Scrapes and archives a Yahoo groups email archives, photo galleries and file contents using the non-public API

MIT License

93 stars 46 forks source link

Replace use of get_file() with download_file() #11

Closed jerrykan closed 4 years ago

jerrykan commented 4 years ago

The Yahoo Groups API is a bit flakey and often returns 400 errors. The get_file() method isn't robust enough to handle these 400 errors and will cause the script to exit immediately. The download_file() method however is able to handle retrying to get files, and with some minor modifications can be a drop-in replacement for get_file(), which should usually allow the script to complete.

IgnoredAmbience commented 4 years ago

Thanks for this, rebased onto master.