IgnoredAmbience / yahoo-group-archiver

Scrapes and archives a Yahoo groups email archives, photo galleries and file contents using the non-public API
MIT License
93 stars 46 forks source link

Only 20 photos per album are being downloaded #36

Closed n4mwd closed 4 years ago

n4mwd commented 4 years ago

I was able to get the photos to download, but then I noticed that it only downloaded 20 max photos from each album. It correctly states the correct number of photos per album, but stops at 20.

I think it has already been mentioned as an enhancement, but it would be nice to have it skip the files that have already been downloaded.

IgnoredAmbience commented 4 years ago

I'm aware of this unfortunate bug, plan is to resolve it tomorrow. (references #22)

n4mwd commented 4 years ago

File download seems to stop after the 11th directory.

n4mwd commented 4 years ago

Any chance you could sanitize the filenames somehow and get rid of illegal windows filename characters such as "/*?" and just change them to '-' ? I tried to go through and manually edit them on yahoo, but its easy for one to slip through and gum up the works.

tripleee commented 4 years ago

There are several related tickets about invalid file names, most of them probably mojibake rather than specifically illegal for Windows. See also e.g. #9

IgnoredAmbience commented 4 years ago

Fixed with 1d8a4b48