[accessibility] Use `<button>` or `<a href="#" role="button">`

Igor-Vladyka / leaflet.browser.print

A leaflet plugin which allows users to print the map directly from the browser

https://igor-vladyka.github.io/leaflet.browser.print/

MIT License

154 stars 76 forks source link

[accessibility] Use `<button>` or `<a href="#" role="button">` #102

Open Malvoz opened 3 years ago

Malvoz commented 3 years ago

The <a> print button is not keyboard focusable/operable. Additionally, it is announced as a "link" using a screen reader (missing role="button"). Otherwise <button type="button"> is recommended, but requires additional styling to reset browser defaults.

See related resources:

https://github.com/Leaflet/Leaflet/blob/bdd7ebf836201550f6d173943b728098b83f40d5/src/control/Control.Zoom.js#L85-L91
The WAI-ARIA Authoring Practices recommended keyboard interactions for buttons.

Malvoz commented 2 years ago

Other potentially helpful resources:

Leaflet Guideline: Test your maps
Leaflet Plugin Authoring Guide: Content Accessibility