search

IgorBanin / Phys434

0 stars 0 forks source link

PR Request lab2 #3

Open IgorBanin opened 5 years ago

IgorBanin commented 5 years ago

@elocj I'm having some issues making an official PR request for the 2nd lab. So until I get that sorted out ill file it under issues. I've finished through question 2, please give me some feedback on my lab. Thanks!

elocj commented 5 years ago

Hey Igor, it's looking good so far, just a couple of comments. For 1D I was wondering where the 25 was coming from so it might be helpful just to leave a comment about that. Additionally, I'm having a hard time following the logic of problem 2A) when you're computing the Rayleigh values. It says to average of observing intervals and I was taking that to mean over multiple convolutions. Regardless I ended up with the same result in that the Gaussian doesn't seem to appear. The difference was that I said I still believe CLT was upholding, it would just require more iterations. Otherwise good work!