search

IgorPerikov / mighty-watcher

Open source made easier
https://itnext.io/open-source-made-easier-aab8aebd849f
MIT License
47 stars 7 forks source link

migrate to coroutines friendly http client #78

Closed JustPRV closed 4 years ago

JustPRV commented 4 years ago

Closes #26

codecov-io commented 4 years ago

Codecov Report

Merging #78 into master will decrease coverage by 14.91%. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #78       +/-   ##
=============================================
- Coverage     75.66%   60.74%   -14.92%     
+ Complexity       43       37        -6     
=============================================
  Files            14       14               
  Lines           226      214       -12     
  Branches         14       13        -1     
=============================================
- Hits            171      130       -41     
- Misses           51       81       +30     
+ Partials          4        3        -1
Impacted Files Coverage Δ Complexity Δ
...ikov/mightywatcher/external/RestGithubApiClient.kt 0% <0%> (-81.64%) 0 <0> (-5)
...m/github/igorperikov/mightywatcher/entity/Issue.kt 37.5% <0%> (-12.5%) 3% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b29720...438fe3b. Read the comment docs.

IgorPerikov commented 4 years ago

@JustPRV Thanks for the PR, merged

IgorPerikov commented 4 years ago

as I expected - coverage in PRs is broken, overall coverage increased due to removing inline function 😄