search

IgorPerikov / mighty-watcher

Open source made easier
https://itnext.io/open-source-made-easier-aab8aebd849f
MIT License
47 stars 7 forks source link

Lightweight di #81

Closed JustPRV closed 4 years ago

JustPRV commented 4 years ago

There is a chance it closes #29

Tested all properties with:

docker run \
-e TOKEN=$MIGHTY_WATCHER_GITHUB_TOKEN \
-e DAYS=100 \
-e PARALLELISM=1 \
-e INCLUDE=kotlin,java \
-e EXCLUDE=ktorio/ktor \
--rm igorperikov/mighty-watcher:local
codecov-io commented 4 years ago

Codecov Report

Merging #81 into master will decrease coverage by 19.21%. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #81       +/-   ##
=============================================
- Coverage     78.03%   58.82%   -19.22%     
+ Complexity       44       37        -7     
=============================================
  Files            14       15        +1     
  Lines           214      221        +7     
  Branches         13        9        -4     
=============================================
- Hits            167      130       -37     
- Misses           44       88       +44     
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...ikov/mightywatcher/external/RestGithubApiClient.kt 0% <0%> (-97.3%) 0 <0> (-6)
.../mightywatcher/external/GithubHttpClientFactory.kt 0% <0%> (ø) 0 <0> (?)
...n/com/github/igorperikov/mightywatcher/Launcher.kt 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...m/github/igorperikov/mightywatcher/entity/Issue.kt 37.5% <0%> (-12.5%) 3% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a16e586...57d4fc8. Read the comment docs.

IgorPerikov commented 4 years ago

@JustPRV thanks for the fixing PR, seems to work fine