search

IgorPerikov / mighty-watcher

Open source made easier
https://itnext.io/open-source-made-easier-aab8aebd849f
MIT License
47 stars 7 forks source link

Track remained x-rate-limit and degrade gracefully #82

Closed JustPRV closed 5 years ago

JustPRV commented 5 years ago

Related to #64

codecov-io commented 5 years ago

Codecov Report

Merging #82 into master will decrease coverage by 21.61%. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #82       +/-   ##
=============================================
- Coverage     75.11%   53.49%   -21.62%     
+ Complexity       42       37        -5     
=============================================
  Files            15       17        +2     
  Lines           221      243       +22     
  Branches          9       10        +1     
=============================================
- Hits            166      130       -36     
- Misses           52      110       +58     
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...ikov/mightywatcher/external/RestGithubApiClient.kt 0% <0%> (-100%) 0 <0> (-4)
.../mightywatcher/external/GithubHttpClientFactory.kt 0% <0%> (-100%) 0 <0> (ø)
...igorperikov/mightywatcher/entity/XRateResources.kt 0% <0%> (ø) 0 <0> (?)
...hub/igorperikov/mightywatcher/entity/XRateLimit.kt 0% <0%> (ø) 0 <0> (?)
...m/github/igorperikov/mightywatcher/entity/Issue.kt 37.5% <0%> (-12.5%) 3% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 234b22c...869bbe7. Read the comment docs.

IgorPerikov commented 5 years ago

tbh, I am still not convinced that delaying is better than fail-fasting. Logging warnings is fine, but user is unable to interrupt the delays to get at least some results, he can interrupt and get none

JustPRV commented 5 years ago

I see your point and I will think about how to achieve this behavior.

JustPRV commented 5 years ago

@IgorPerikov, not sure if you get a notification but I have updated PR according to your comments. Please take look.

IgorPerikov commented 5 years ago

@JustPRV I got notification, took a skim look. Really short on time right now, sorry

JustPRV commented 5 years ago

@IgorPerikov There is nothing to apologize for. I really appreciate that you react on all my PR's and comments so fast, thank you!