Add ability to add custom app market servers and api docs

IgorTimofeev / MineOS

Home of MineOS and it's software for OpenComputers mod

Other

733 stars 191 forks source link

Add ability to add custom app market servers and api docs #594

Closed finnaminope closed 3 months ago

finnaminope commented 3 months ago

I was thinking of making my own app market. then i realized i would have to make everything from scratch. then i made this issue.

finnaminope commented 3 months ago

Im sorry for being nondiscript but thats what happened

finnaminope commented 3 months ago

i will probably make a cli version for MineOS first

finnaminope commented 3 months ago

I just realized the os development has stopped so im going to be making this in my fork. i may make a pull request eventually.

PublicVoidUpdate commented 3 months ago

you could probably alter the existing app if you find where the url is stored.

IgorTimofeev commented 3 months ago

The AppMarket API was developed while studying at the university and contains many unconventional patterns that should not be used in modern production. The source code is closed for security reasons. I don't want to waste time shutting down and cleaning up possible security breaches in a "homemade" project I did for fun 8 years ago, so sorry, bro, no sources

If you still want to do some reverse engineering and dive deep into the structure of requests - go ahead, there are no rules or restrictions. If we were friends, I would have no problem sending you sources and a database dump e to analyze and reproduce the market from scratch, but... yeah

Smok1e commented 3 months ago

I don't think this is something that the opensource community is ready to see

CoolCat467 commented 3 months ago

There is one detail I am wondering about since we are on this topic, how is statistics "most popular user" calculated?

Smok1e commented 3 months ago

There is one detail I am wondering about since we are on this topic, how is statistics "most popular user" calculated?

The most popular user is the one whose publications have the most reviews number

CoolCat467 commented 3 months ago

@finnaminope I recently just finished a re-implementation of the app market server in Python. Might have a few bugs still, but it's done now: https://github.com/CoolCat467/MineOS-Market-Server

finnaminope commented 2 months ago

@CoolCat467 you are a lifesaver. I actually forgot this project. I will look at the code and try it out.