search

Igorbunow / avr-uip

Automatically exported from code.google.com/p/avr-uip
0 stars 0 forks source link

KSZ8851SNL initialization code bug #14

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The default initialization code for KSZ8851SNL chip checks for the fixed chip 
ID defined by CHIP_ID_8851_16 (0x8870).

This is incorrect, as the CIDER registry defines lower bits [3..1] as revision 
number what may change (It is actually 0x8872 currently).

Please change the init code references to chip ID as following:

...

if ((dev_id & 0xFFF0) == CHIP_ID_8851_16) 

...

Original issue reported on code.google.com by andrus.a...@gmail.com on 6 Dec 2011 at 10:34

GoogleCodeExporter commented 9 years ago 
Good catch.

Original comment by qarc...@gmail.com on 7 Dec 2011 at 5:28

GoogleCodeExporter commented 9 years ago 

Check in fix per your report.  Thank you for finding this issue.

 svn ci . -m " correct chip id check per issue 14 reporter.
> "
Sending        ksz8851/ksz8851.c
Transmitting file data .
Committed revision 155.

Original comment by qarc...@gmail.com on 7 Dec 2011 at 5:31