Igosuki / binance-rs-async

Async client for the Binance APIs
https://crates.io/crates/binance-rs-async
Other
184 stars 113 forks source link

Support Universal Transfer #29

Closed nvxxu2i closed 2 years ago

nvxxu2i commented 2 years ago

Hello @Igosuki ,

I love this library of yours, and I'm considering adopting the previous transfer implementations for the "Universal Transfer", so more transfer scenarios can be covered. https://binance-docs.github.io/apidocs/spot/en/#user-universal-transfer-user_data

I have multiple questions in this regard:

Thanks, Ádám

Igosuki commented 2 years ago

Hi, the library is actively maintained. I just focus on a different project so there haven't been any updates by me for a while. Apparently, this endpoint belongs to a new collection of endpoints regarding Wallet management, so you should create a new file called wallet.rs or a folder with /wallet/mod.rs /wallet/model.rs and include all the related endpoints and structs there, you can take inspiration from other files such as margin.

Igosuki commented 2 years ago

All these endpoints are private (indicated by USER_DATA in the doc) and there is a single method to authenticate here https://github.com/Igosuki/binance-rs-async/blob/master/src/client.rs#L220 which is already called by the various get/post/put/delete methods in client.rs

nvxxu2i commented 2 years ago

Well, I have created a proof of concept in this commit (https://github.com/nvxxu2i/binance-rs-async/commit/0927405ed6e7703bed5fcaa77b42ab060727addf) and it seems to be working well, so stay tuned for the production-grade implementation.

Igosuki commented 2 years ago

You can push a draft PR if you need help.

Igosuki commented 2 years ago

Wallet API #33