search

Igosuki / compass-mixins

A collection of compass' stylesheet for bower dependencies and libsass
Other
592 stars 197 forks source link

Fix for Deprecation Warning: Using / for division outside of calc() #122

Closed SiriVadlapudi closed 2 years ago

SiriVadlapudi commented 2 years ago

This PR will fix the deprecated warning on Using / or * outside the calc()

hiratsuka-r commented 2 years ago

@SiriVadlapudi Thank you for the fix! I checked the contents.

I'm curious about only one point, so let me ask you a question. It seems that only this line is not enclosed in calc. Is there a warning...? https://github.com/Igosuki/compass-mixins/blob/77f9f98d5c6463c3ecc5297629b4c50f11db02c4/lib/compass/typography/_vertical_rhythm.scss#L184

I have no objection to other contents.

SiriVadlapudi commented 2 years ago

@SiriVadlapudi Thank you for the fix! I checked the contents.

I'm curious about only one point, so let me ask you a question. It seems that only this line is not enclosed in calc. Is there a warning...?

https://github.com/Igosuki/compass-mixins/blob/77f9f98d5c6463c3ecc5297629b4c50f11db02c4/lib/compass/typography/_vertical_rhythm.scss#L184

I have no objection to other contents.

@hiratsuka-r there was no warning for that particular line.

SiriVadlapudi commented 2 years ago

@hiratsuka-r I just pushed fix for that line too. Also, there are no warnings.

Igosuki commented 2 years ago

Checked it out and it works.

Closes #121

SiriVadlapudi commented 2 years ago

@Igosuki @hiratsuka-r Could you please release the new version, so that we could use the version number for further use?