Igosuki / compass-mixins

A collection of compass' stylesheet for bower dependencies and libsass
Other
592 stars 198 forks source link

"Sass -> CSS (may only compare numbers)" error when using with node-sass #17

Closed PandaWhisperer closed 10 years ago

PandaWhisperer commented 10 years ago

I am attempting to replace compass in my Node.js project with a pure JS-based solution. So I installed the compass-mixins module and symlinked it into my stylesheets directory.

I am seeing the following error now:

"Sass -> CSS (may only compare numbers) styles/compass/css3/images"

Any ideas what this means or how to fix it?

michaek commented 10 years ago

I think I have a fix to this already in my company's fork. I'll take a look and see about getting it merged in (if I'm right).

PandaWhisperer commented 10 years ago

Thanks, that would be awesome!

On Mon, Oct 6, 2014 at 4:23 AM, Michael Hellein notifications@github.com wrote:

I think I have a fix to this already in my company's fork https://github.com/DealerDotCom/compass-mixins. I'll take a look and see about getting it merged in (if I'm right).

— Reply to this email directly or view it on GitHub https://github.com/Igosuki/compass-mixins/issues/17#issuecomment-58003935 .

michaek commented 10 years ago

Here's the PR that should resolve that. https://github.com/Igosuki/compass-mixins/pull/18

PandaWhisperer commented 10 years ago

Seems to work for me. After including compass/functions my stylesheet compiles fine.

michaek commented 10 years ago

Awesome. I just merged these changes into this repository, and a release should be coming. I think @Igosuki is the only user with write access to the npm project.

PandaWhisperer commented 10 years ago

I have noticed one issue with the new version. The stylesheet I'm using has the following mixin:

@mixin flexbox {
  display: -webkit-box !important;
  display: -moz-box !important;
  display: -ms-box !important;
  display: -o-box !important;
  display: box !important;
}

// the mixin is used in other places, but also this:
.flexbox {
  @include flexbox;
}

For some reason, after compilation, this comes out to

.flexbox {
  display:-ms-box !important;
  display:-o-box !important;
  display:box !important;
}

In other words, the -webkit- and -moz- versions are missing. The same appears to be true for the other classes that use the mixin. Other mixins related to flexbox, for instance box-orient, work fine with these prefixes.

Not sure what's going on here and whose fault it is (I'm using harp, which uses node-sass to compile SCSS). May or may not relate to #15.

Any thoughts on this?

michaek commented 10 years ago

Can you open this as a new issue, please? It doesn't appear to be related to the number comparison you originally reported.

PandaWhisperer commented 10 years ago

Will do.

PandaWhisperer commented 10 years ago

See #22

michaek commented 10 years ago

Thanks!

OysteinAmundsen commented 9 years ago

Is there a release for this coming soon? I've noticed that this repository does not contain the latest version of the compass mixins. Will these be merged in as well?