Igosuki / compass-mixins

A collection of compass' stylesheet for bower dependencies and libsass
Other
592 stars 197 forks source link

Broken on node-sass@^3.5.0 #84

Closed loganfsmyth closed 8 years ago

loganfsmyth commented 8 years ago

Compiling this library with gulp-sass using node-sass 3.5.0, this is now broken and throwing

    node_modules/compass-mixins/lib/compass/functions/_lists.scss
Error: Functions may not be defined within control directives or other mixins.
        on line 81 of node_modules/compass-mixins/lib/compass/functions/_lists.scss
>>   @function compact($vars...) {
   --^
loganfsmyth commented 8 years ago

Sounds like it was a bug that this worked previously: https://github.com/sass/node-sass/issues/1456

phazei commented 8 years ago

+1 Please fix ASAP

Qing-xiu commented 8 years ago

+1

hellonoam commented 8 years ago

+1

dschaller commented 8 years ago

+1

jmphilli commented 8 years ago

+1

cbrwizard commented 8 years ago

+

Kopatch commented 8 years ago

+1

lxlang commented 8 years ago

+1

VasuLief commented 8 years ago

+1

VasuLief commented 8 years ago

you can replace this package with https://www.npmjs.com/package/compass-sass-mixins and it should work just fine

fustic commented 8 years ago

+1

Predjo commented 8 years ago

+1

VasuLief commented 8 years ago

you could also set a fixed version of node-sass@3.4.2 in your packages.json

E-VANCE commented 8 years ago

you could also set a fixed version of node-sass@3.4.2 in your packages.json

Didn't do the trick for me... +1

dschaller commented 8 years ago

If you're using grunt-sass it requires node-sass as well so you'd have to shrinkwrap in order to pin

xzyfer commented 8 years ago

Fix PR'd in https://github.com/Igosuki/compass-mixins/pull/86

navgarcha commented 8 years ago

+1

fetis commented 8 years ago

It's more than 11 days since fix is available. Any ideas when it'll be merged?

mdular commented 8 years ago

+1 for an ETA on the fix

jsha09 commented 8 years ago

+1

xzyfer commented 8 years ago

PR is updated a passing. Turn out the transition mixin has never worked on offical Sass compiler.

GFoley83 commented 8 years ago

+1 I'm using grunt-sass like @dschaller which requires node-sass. Adding the node-sass dependency manually in the package.json solves the issue for me:

  "devDependencies": {
    ...
    "node-sass": "3.4.2",
    ...
  }

Remember to either rebuild node-sass or delete the module folder and re-install.

orzarchi commented 8 years ago

+1

svaldi commented 8 years ago

+1 Since, there is a problem with the node-sass also in the darwin-x64-48_binding.node when you use a node-sass 3.4.2 version. If we use 3.4.2 temporary this is not a favorable option.

jeanschmidt commented 8 years ago

+1

ale-grosselle commented 8 years ago

+1, please!

runderworld commented 8 years ago

+1 por favor!

henk23 commented 8 years ago

+1

xzyfer commented 8 years ago

Hello everyone, I've gotten in contact with @Igosuki and I'll now be helping out maintaining this project. This should prevent further breakages.

xzyfer commented 8 years ago

compass-mixins@0.12.8 has been released

svaldi commented 8 years ago

Thank you so much to everyone!!!!!

ismaail commented 6 years ago

Hi, I'm getting this error trying to compile mdb.scss from MDBootstrap

Module build failed: ModuleBuildError: Module build failed: 
    @function set-notification-text-color($color) {
             ^
      Functions may not be defined within control directives or other mixins.
      in /home/user/project/assets/MDBootstrap/scss/core/_mixins.scss (line 215, column 15)
xzyfer commented 6 years ago

This package is no longer supported. We recommended using http://bourbon.io