search

Igosuki / compass-mixins

A collection of compass' stylesheet for bower dependencies and libsass
Other
592 stars 197 forks source link

Invalid Sass #85

Closed xzyfer closed 8 years ago

xzyfer commented 8 years ago

The following is not valid Sass code

@if not(function-exists(compact)) {
  @function compact($vars...) {
    $list: ();
    @each $var in $vars {
        @if $var {
            $list: append($list, $var, comma);
        }
    }
    @return $list;
  }
}

From: https://github.com/Igosuki/compass-mixins/blob/8d93bef3e982cba3420bd16c04a99fabf4e3399e/lib/compass/functions/_lists.scss#L80-L90

This code produces the following error in Sass

Error: Functions may not be defined within control directives or other mixins.
        on line 2 of test.scss
  Use --trace for backtrace.

This previously worked in Node Sass due to a bug in LibSass which has since been fixed. As a result this library no longer compiles.

dclowd9901 commented 8 years ago

+1, got this error when node-sass updated to 3.5 from 3.4.2

xzyfer commented 8 years ago

Fix PR'd in https://github.com/Igosuki/compass-mixins/pull/86

xzyfer commented 8 years ago

Hello everyone, I've gotten in contact with @Igosuki and I'll now be helping out maintaining this project. This should prevent further breakages.

xzyfer commented 8 years ago

compass-mixins@0.12.8 has been released