search

Igosuki / signalr-rs

Actix Websocket based implementation of Signalr
MIT License
19 stars 6 forks source link

JWT authentication support #7

Open bradnelson opened 2 years ago

bradnelson commented 2 years ago

Is JWT authentication supported? I don't see any way to do this, which the server application I wish to connect to requires. If not, are there any plans to support JWTs?

Igosuki commented 2 years ago

Hello Bradley, if you wish to see jwt you will have to add the support yourself and make a PR. It's absolutely fine to use other libraries and put it behind a feature gate.

Le mar. 8 mars 2022 à 20:59, Bradley Nelson @.***> a écrit :

Is JWT authentication supported? I don't see any way to do this, which the server application I wish to connect to requires. If not, are there any plans to support JWTs?

— Reply to this email directly, view it on GitHub https://github.com/Igosuki/signalr-rs/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADDFBSLAYGWHU732WH3I7DU66WTRANCNFSM5QHK6X4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

bradnelson commented 2 years ago

Thanks for the quick response. Not sure my time constraints will allow, but I'll see what I can do 👍

Igosuki commented 2 years ago

Here is an article to help you : https://blog.logrocket.com/jwt-authentication-in-rust/ There is a connect method in the code where connection happens, which you can patch with that mechanic !

bradnelson commented 2 years ago

Thanks, I will look through that one!

An unrelated question - will this repo work for standard SignalR messaging? A coworker, who has looked a bit deeper at this library, said it seemed like there were some weird message formatting going on that isn't standard SignalR, that might be specific to the bittrex formatting. Just wanted to check before I dive too deep that if I add the JWT auth, that the other parts of the repo will work for our needs.

Igosuki commented 2 years ago

I originally developed it for Bittrex, but anything Bittrex specific should be optional.

Le jeu. 10 mars 2022 à 19:22, Bradley Nelson @.***> a écrit :

Thanks, I will look through that one!

An unrelated question - will this repo work for standard SignalR messaging? A coworker, who has looked a bit deeper at this library, said it seemed like there were some weird message formatting going on that isn't standard SignalR, that might be specific to the bittrex formatting. Just wanted to check before I dive too deep that if I add the JWT auth, that the other parts of the repo will work for our needs.

— Reply to this email directly, view it on GitHub https://github.com/Igosuki/signalr-rs/issues/7#issuecomment-1064360720, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADDFBXHT6CCZ24K25RKJRTU7I4VFANCNFSM5QHK6X4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

Igosuki commented 2 years ago

We could add some e2e testing tool that runs a test suite using a C# SignalR server.