search

IharTsykala / Ais__Telegram-clone

0 stars 0 forks source link

Review #1

Open IlyaMokin opened 4 years ago

IlyaMokin commented 4 years ago

@IharTsykala, the Telegram looks more or less good. A few notes:

IharTsykala commented 4 years ago

I made:

  1. equal place between title and amounts members in header room. image
  2. add different types message in messageCard. Look in 1 to 4 rooms. image
  3. carry out new feature - reply message block. Click on reply in messageCard. image ps. Maybe I didn't understand you and perhaps I made mistakes again. Do you want this feature from me?
IlyaMokin commented 4 years ago

Thanks, looks fine now. It can be closed. Also I've noticed that we don't have your PRs for JS tasks https://github.com/AisBrestEDU/js-assignments/pulls?q=is%3Apr+Tsykala

IharTsykala commented 4 years ago

Sorry, probably i didnt understand task. I made all pr from branch task to master my repository https://github.com/IharTsykala/js-assignments/pulls?q=is%3Apr+is%3Aclosed
I carry out this task in april 2019 in rolling scopes and I forked from mikhama/js-assignments. Now I can't to do fork from your repository and I haven't been having opportunity to do pr in your repository Must I remove old repository https://github.com/IharTsykala/js-assignments and after do I need fork in your repository?