Bug: Inviscid burgers example

IhmeGroup / quail

A lightweight discontinuous Galerkin code for teaching and prototyping

GNU General Public License v3.0

52 stars 20 forks source link

Bug: Inviscid burgers example #10

Closed ericjching closed 3 years ago

ericjching commented 3 years ago

Inviscid burgers example doesn't work for master branch anymore (still works for release branch)

ericjching commented 3 years ago

it's because of the y_shift added recently, so it's not really a bug. can y_shift just be set to 0 by default?

bornhoft commented 3 years ago

y_shift interacts poorly with the boundary condition. This needs to be investigated further. Current fix removes y_shift. Can be added later if needed.