IhmeGroup / quail

A lightweight discontinuous Galerkin code for teaching and prototyping
GNU General Public License v3.0
51 stars 20 forks source link

Bug: PPL inconsistent when using Legendre basis #2

Closed bornhoft closed 3 years ago

bornhoft commented 3 years ago

Inconsistent results were obtained when using Legendre polynomials with the positivity preserving limiter. Assuming issue is in positivitypreserving.py. Needs further investigation.

ericjching commented 3 years ago

Originally assumed nodal basis when modifying the coefficients. Modal bases need to be modified in a different way. The hierarchic H1 triangular basis is not yet compatible though, and a check has been added for that.