IhmeGroup / quail

A lightweight discontinuous Galerkin code for teaching and prototyping
GNU General Public License v3.0
52 stars 20 forks source link

Extension of Quail for handling diffusion terms #26

Closed bornhoft closed 3 years ago

bornhoft commented 3 years ago

This pull request includes the addition of handling second-order terms in DG via the SIP discretization. This includes the following:

I have perhaps missed some of the changes here but I believe we have most things covered. Convergence tests have been completed for 1D/2D constant advection diffusion on both DG/ADER and on quads/tris for DG. Convergence tests have also been completed for 2D manufactured solution for DG (and almost completed for ADERDG).

Please feel free to reach out with more specific questions or comments. I believe that my list includes most of the major changes but this is a reasonably sized pull request so I imagine I have missed a few. Thanks for the extra set of eyes!

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@477b7c0). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   26.10%           
=======================================
  Files           ?       39           
  Lines           ?     6366           
  Branches        ?        0           
=======================================
  Hits            ?     1662           
  Misses          ?     4704           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 477b7c0...df4c191. Read the comment docs.