search

Ihmoda / github-protocol

0 stars 2 forks source link

39. Provide "Write Access" to all members of team for the Master branch #97

Open katiash opened 6 years ago

katiash commented 6 years ago

All members will need write access as a part of the 2-pass review project management process:

  1. a member submits pull request to staging area (the Master Branch), with a quick note/message about what was added or changed.

  2. They send the PullRequest link in mattermost... like this EXAMPLE: "PR ready to be reviewed: https://github.com/RyanGKist/LearnUpProject/pull/5"

  3. a different member of the team clones that branch to test the new changes, tells people via Mattermost that they are grabbing/testing the changes

  4. Review/Test and identify any issues/changes, communicate that to the member who submitted the changes, via the pull request comments on GitHub.

  5. Any issues are reviewed and fixed by the submitter/owner

  6. In Mattermost the submitter/owner, will notify that the changes can be reviewed by the next member of the team.

  7. That member repeats steps #3 and #4, and the owner fixes ay issues (step #5). then skip to step #8 when ready.

  8. After any changes/resolutions are settled. The final pull request is submitted/updated by the owner.

  9. The changes will be merged to Master by the second reviewer.