search

IjzerenHein / famous-flex

Animatable layouts, FlexScrollView & widgets for famo.us.
MIT License
279 stars 44 forks source link

Added warning to ListLayout when options.spacing is non-numeric #114

Closed tjclement closed 9 years ago

tjclement commented 9 years ago

The CollectionLayout supports array-based spacing options, and the ListLayout does not.

If an array spacing option is given to ListLayout (after switching from CollectionLayout back to ListLayout for example), it does not warn or throw an exception, but rather doesn't show any renderables without notice. This commit fixes that behaviour by letting the developer know that the spacing should be numeric.
IjzerenHein commented 9 years ago

Awesome Tom! Can you make this pull request on the develop branch, I can only accept pull requests on that branch.

tjclement commented 9 years ago

Sure thing: https://github.com/IjzerenHein/famous-flex/pull/115