Mobx 6 breaking changes

IjzerenHein / firestorter

Use Google Firestore in React with zero effort, using MobX 🤘

http://firestorter.com

MIT License

378 stars 50 forks source link

Mobx 6 breaking changes #115

Closed kaminskypavel closed 3 years ago

kaminskypavel commented 3 years ago

Mobx 6 dropped decorate() , there's a long discussion here

@IjzerenHein are you willing to release a major if ill submit a PR?

IjzerenHein commented 3 years ago

@kaminskypavel Definitely!

thirdman commented 3 years ago

Just a gentle +1 for this. :D

damonmaria commented 3 years ago

Quick attempt at a PR. Tried to change the 2 uses of decorate() to makeObservable() (inside the constructors) but this breaks 7 tests. Haven't looked any further than that. Will need a detailed look through the breaking changes of Mobx 6.

IjzerenHein commented 3 years ago

MobX 6 is now supported! 🤘🤘🤘🤘🤘🤘 https://github.com/IjzerenHein/firestorter/releases/tag/v3.0.0