search

IjzerenHein / firestorter

Use Google Firestore in React with zero effort, using MobX 🤘
http://firestorter.com
MIT License
378 stars 50 forks source link

Remove require() #133

Closed aaroniker closed 1 year ago

aaroniker commented 3 years ago

Really like this package! But since im using Snowpack it would be great to remove all require() and replace them with import to not mix ESM and CJS code.

Discussion about this: https://github.com/snowpackjs/snowpack/discussions/1321

IjzerenHein commented 3 years ago

I guess you are referring to the lodash imports? Correct?

const isEqual = require('lodash.isequal');
aaroniker commented 3 years ago

Correct :) (I could also open a PR for this)

IjzerenHein commented 3 years ago

Alright.

(I could also open a PR for this)

Yes please :)

aaroniker commented 3 years ago

Just did https://github.com/IjzerenHein/firestorter/pull/134 (Just saw the build somehow failed - will fix)

IjzerenHein commented 2 years ago

The build tooling has been completely overhauled. There should no longer be any require calls in the code. Please upgrade to v4 and let me know in case there are still issues. https://github.com/IjzerenHein/firestorter/releases/tag/v4.0.0