Typescript: fetch() should use Document generic

IjzerenHein / firestorter

Use Google Firestore in React with zero effort, using MobX 🤘

http://firestorter.com

MIT License

378 stars 50 forks source link

Typescript: fetch() should use Document generic #64

Closed damonmaria closed 5 years ago

damonmaria commented 5 years ago

In Document: public async fetch(): Promise<Document> should use Document<T>

IjzerenHein commented 5 years ago

Hi! I'm noticing that I have too little time and need some help maintaining this repo. Would you be interested in being a collaborator? cheers, Hein

damonmaria commented 5 years ago

I don't have a huge amount of time but Firestorter is a valuable package for us, and pretty awesome in general. Also know that while having dozens of private (company) repos I haven't worked as a collaborator on an open source repo before. But yes, I'm happy to work on this.

As an easy first step I could do a PR for this issue?

IjzerenHein commented 5 years ago

Yes that would be awesome Damon!

damonmaria commented 5 years ago

PR: #66

IjzerenHein commented 5 years ago

Thanks Damon, I've just released this fix as https://github.com/IjzerenHein/firestorter/releases/tag/v1.2.1 cheers, Hein