Seemingly unused bits - Githubissues

IjzerenHein / kiwi.js

Fast TypeScript implementation of the Cassowary constraint solving algorithm 🖖

Other

249 stars 24 forks source link

Seemingly unused bits #9

Open joshuahhh opened 5 years ago

joshuahhh commented 5 years ago

I've been reading the code a bit, and am confused by a few bits that seem not to be used.

createMap takes a compare argument, but this isn't used. I don't think the various compare functions (like Constraint.compare) are used anywhere other than calls to createMap, so they are unused too.
The code in the thirdparty directory doesn't seem to be used.

Is my interpretation right? If so, I think these ought to be removed, since it's confusing to have them hanging around.

Thanks a bunch for any clarification!

IjzerenHein commented 5 years ago

Hi, thanks for pointing out these things. Last week a PR was merged that changed a couple things, one of those being that a faster alternative to the third-party code was added. The third-party code is now indeed obsolete and I've removed it from the source.

As for the compare argument in createMap, I'm not sure to be honest. If you feel there is unused code that can be removed, feel free to submit a PR for this. Btw, are you trying to reduce the bundle size or something like that?

Cheers and thanks for the feedback.

joshuahhh commented 5 years ago

Great! I'll submit a PR for the compare stuff.

(I'm motivated by trying to keep the source code understandable, not by bundle size. It can be very distracting and confusing to have parts of a code base that don't serve a function.)

Thanks for your help!

IjzerenHein commented 5 years ago

Hey. I think these issues have been dealt with in the latest release. Can this issue be closed? Cheers, Hein