search

IjzerenHein / react-native-bundle-visualizer

See what packages are increasing your react-native bundle size 📦
MIT License
1.44k stars 42 forks source link

Visualizer script fails when package name is scoped #21

Closed cameronbell closed 4 years ago

cameronbell commented 4 years ago

I'm using v2. My RN app lives in a package within a monorepo, so the name field in the package.json is @org/appName. The script fails when trying to create the tmp directory because of the slash in the package name. I was able to run the script no problem by changing the package name, but it would be ideal if this package could accommodate this kind of package name.

IjzerenHein commented 4 years ago

Alright, good find! Will fix this in the next update, thanks for reporting this.

ofiron01 commented 4 years ago

@IjzerenHein I've created a PR #23 to fix this issue. Was able to reproduce and this PR resolves it. @cameronbell

IjzerenHein commented 4 years ago

Awesome, thanks for the fix @ofiron01 👍 👍 I've released a new version which includes the fix: https://github.com/IjzerenHein/react-native-bundle-visualizer/releases/tag/v2.1.1

ofiron01 commented 4 years ago

@IjzerenHein I can confirm the issue doesn't reproduce anymore

IjzerenHein commented 4 years ago

Awesome @ofiron01 ! @cameronbell let me know whether I can close this. Cheers

cameronbell commented 4 years ago

Fixed for me as well. Thanks!