search

IjzerenHein / react-navigation-shared-element

React Navigation bindings for react-native-shared-element 💫
https://github.com/IjzerenHein/react-native-shared-element
MIT License
1.27k stars 124 forks source link

[v5] - iOS gestures #56

Open davesimtech opened 4 years ago

davesimtech commented 4 years ago

Firstly I'd like to thank everyone involved for getting this awesome library to work with react-navigation v5!

Not sure if this is a bug or if it is working as intended - however the animation between screens doesn't work when using gestures on iOS.

recording

mrousavy commented 4 years ago

I've noticed this issue too. The cardInterpolatorStyle will be called when using gestures, I tried to play around and render the SharedElement transition there but I haven't found a way to do so. I've found this article on how it would work: http://www.reactnativediary.com/2017/04/22/react-navigation-shared-element-transition-3.html

Anyone knows how to get working gesture transitions? The gesture transition looks pretty ugly since I'm animating the opacity property in my cardInterpolatorStyle...

davesimtech commented 2 years ago

I thought I'd revisit this issue this week and have created a fork which enables transitions on gesture. There is still some bugginess that I'm hoping to resolve, but it would be great to get another pair of eyes on it.

https://github.com/davesimtech/react-navigation-shared-element

p-syche commented 2 years ago

@davesimtech thank you for working on this issue. Can you create a PR from your fork? It will be easier to see what changes you made.